Open
Conversation
|
Hi @groorj , I stumbled across this change whilst looking at your fork. I was surprised to find the functionality, as there isn't an entry in the config example. After digging a little deeper I think I have discovered why. It looks as if this new addition is inconsistent with the rest of the project in that it doesn't offer and or observe the 'preserve' list. I'd suggest this is a somewhat dangerous inconsistency, as it could result in unexpected behaviour. My personal recommendation would be to rework this to observe the same preserve list structure as the rest of the services. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ville Seppänen,
I added support to EC2 instances termination. Please take a look at the code at your earliest convenience and let me know what you think.
Thanks,
Gustavo